Skip to content

Create a single universal executable for macOS #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 10, 2024
Merged

Create a single universal executable for macOS #964

merged 4 commits into from
Jul 10, 2024

Conversation

MatteoPologruto
Copy link
Contributor

@MatteoPologruto MatteoPologruto commented Jun 12, 2024 •
edited
Loading

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

Instead of relying on the Rosetta translation to distribute the Agent for arm architectures, a single universal executable is created. It runs natively on both Apple silicon and Intel-based Mac computers.

  • Does this PR introduce a breaking change?

No

  • Other information:

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Jun 12, 2024
@MatteoPologruto MatteoPologruto self-assigned this Jun 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.04%. Comparing base (04414e2) to head (78ed8cc).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #964   +/-   ##
=======================================
  Coverage   20.04%   20.04%           
=======================================
  Files          42       42           
  Lines        2569     2569           
=======================================
  Hits          515      515           
  Misses       1968     1968           
  Partials       86       86
Flag Coverage Δ
unit 20.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MatteoPologruto MatteoPologruto force-pushed the macos-arm-release branch 2 times, most recently from e87f70a to e7b9e3c Compare June 12, 2024 15:46
@per1234 per1234 added the os: macos Specific to macOS operating system label Jun 12, 2024
umbynos
umbynos reviewed Jun 13, 2024
View reviewed changes
@MatteoPologruto MatteoPologruto force-pushed the macos-arm-release branch 5 times, most recently from 4c7bd8b to f5f10a1 Compare June 17, 2024 13:08
@MatteoPologruto MatteoPologruto marked this pull request as ready for review June 17, 2024 13:08
@MatteoPologruto MatteoPologruto linked an issue Jun 17, 2024 that may be closed by this pull request
Add Mac arm64 release #946
Closed
6 tasks
umbynos
umbynos reviewed Jun 21, 2024
View reviewed changes
@umbynos
Copy link
Contributor

umbynos commented Jun 21, 2024

Have you had the chance to test the autoupdate mechanism?
Another doubt that comes to my mind is: have you tested that when using the cloud editor the tools install is performed successfully? (selecting the correct macos arm64 tool if present)?

@Xayton
Copy link
Contributor

Xayton commented Jul 9, 2024 •
edited
Loading

The tests were good:

  • The auto-update mechanism works correctly. The tests found no issues (but an opportunity for improvement).
  • The tools installation was successful: the arm64 version of the executable will try to download the "closes" version, so arm64 if available, or amd64 otherwise. In both cases the download works.

@Xayton Xayton self-requested a review July 9, 2024 14:16
@MatteoPologruto MatteoPologruto merged commit da1fa2e into arduino:main Jul 10, 2024
@MatteoPologruto MatteoPologruto deleted the macos-arm-release branch July 10, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xayton Xayton Xayton approved these changes

+1 more reviewer

@umbynos umbynos umbynos left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@MatteoPologruto MatteoPologruto

Labels
os: macos Specific to macOS operating system topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Mac arm64 release
5 participants
@MatteoPologruto @codecov-commenter @umbynos @Xayton @per1234